Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12352 )
Change subject: Store GSN address in libosmocore struct ...................................................................... Patch Set 2: > > You are breaking the ABI > > That's not a library - what kind of ABI breakage are you talking > about? > My bad, I somehow had the impression the code was in libosmocore. > > basically not using the extra field "type" of the new struct. > > That's a subject for follow-up patches: I don't want to mix > automated code changes with manual ones. Then please state so in the commit description. Until I see a user for the "type" field in a forthcoming patch, I'll keep the -1. -- To view, visit https://gerrit.osmocom.org/12352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed32a91483dc608c47df77869033a6e891e9e6a Gerrit-Change-Number: 12352 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 18 Dec 2018 18:15:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
