Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/12352 )
Change subject: Store GSN address in libosmocore struct ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12352/2/include/osmocom/sgsn/gtphub.h File include/osmocom/sgsn/gtphub.h: https://gerrit.osmocom.org/#/c/12352/2/include/osmocom/sgsn/gtphub.h@377 PS2, Line 377: struct osmo_gsn_address addr; > You are breaking ABI here, length of struct is different. […] But why would one want to have two representations of a GSN address? When to use which? If osmo_gsn_address is a superset why wouldn't we want to use it everywhere? -- To view, visit https://gerrit.osmocom.org/12352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed32a91483dc608c47df77869033a6e891e9e6a Gerrit-Change-Number: 12352 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Fri, 28 Dec 2018 14:52:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
