Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12352 )
Change subject: Store GSN address in libosmocore struct ...................................................................... Patch Set 2: I'd say, ok, fine, and since we're in the sgsn in a sub-area called gtphub, I don't even see how an ABI change is a problem. But I am puzzled why the gtphub code is coming up at this point in time. How are we currently interested in that, how did you even end up spotting the gsn_addr? -- To view, visit https://gerrit.osmocom.org/12352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed32a91483dc608c47df77869033a6e891e9e6a Gerrit-Change-Number: 12352 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Sat, 05 Jan 2019 03:56:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
