Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12352 )
Change subject: Store GSN address in libosmocore struct ...................................................................... Patch Set 2: > That's orthogonal to this patch I think: regardless of the use of > extra field in the struct there's no point in keeping effectively a > local duplicate of a struct available in a shared library we're > linked against anyway. It's not a local duplicate struct, it's a struct with an extra field not being used, so I so far no see a good reason to include this patch. Specially because I think that extra field is really not needed since the type can be inferred from length (like we do in most places in struct in46addr in osmo-ggsn and libgtp). Send forthcoming patches using that field and I'll re-check then. -- To view, visit https://gerrit.osmocom.org/12352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed32a91483dc608c47df77869033a6e891e9e6a Gerrit-Change-Number: 12352 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 18 Dec 2018 18:27:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
