Jeff King <p...@peff.net> writes:
> I agree that this deals with the performance concerns by caching the
> default_abbrev_len and starting there. I still think it's unnecessarily
> invasive to touch get_short_sha1() at all, which is otherwise only a
> reading function.
> So IMHO, the best combination is the init_default_abbrev() you posted in
> , but initialized at the top of find_unique_abbrev(). And cached
> there, obviously, in a similar way.
Hmm. I am undecided; both approaches look OK to me.