jcamachor commented on a change in pull request #812: Hive 22324
URL: https://github.com/apache/hive/pull/812#discussion_r337288760
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java
 ##########
 @@ -117,8 +119,7 @@ public Double getRowCount(Join join, RelMetadataQuery mq) {
     return rowCount;
   }
 
-  @Override
-  public Double getRowCount(SemiJoin rel, RelMetadataQuery mq) {
+  public Double getRowCountSemi(Join rel, RelMetadataQuery mq) {
 
 Review comment:
   We should replace this call by `public Double getRowCount(HiveSemiJoin rel, 
RelMetadataQuery mq)`. The metadata provider will call the correct method in 
the class hierarchy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to