jcamachor commented on a change in pull request #812: Hive 22324
URL: https://github.com/apache/hive/pull/812#discussion_r337246824
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptMaterializationValidator.java
##########
@@ -108,7 +108,7 @@ public RelNode visit(HiveFilter filter) {
@Override
public RelNode visit(HiveJoin join) {
- if (join.getJoinType() != JoinRelType.INNER) {
+ if (join.getJoinType() != JoinRelType.INNER && !join.isSemiJoin()) {
Review comment:
Semijoin is not supported for the rewriting. Hence we do not need to add the
additional conjunct, i.e., we bail out unless join type is inner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
