jcamachor commented on a change in pull request #812: Hive 22324
URL: https://github.com/apache/hive/pull/812#discussion_r337251138
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java
##########
@@ -547,7 +547,7 @@ public static PKFKJoinInfo extractPKFKJoin(
final PKFKJoinInfo cannotExtract =
PKFKJoinInfo.of(false, null, null);
- if (joinType != JoinRelType.INNER) {
+ if (joinType != JoinRelType.INNER && !join.isSemiJoin()) {
Review comment:
The call to this method originated from `HiveRelMdRowCount`. iirc that
method could only be called with Hive join operator previously (not semijoin).
It seems we should not hit this logic with semijoin since `HiveRelMdRowCount`
has special logic for semijoin operator? Are we calling this in any other
place? Are we sure that if we support SJ here, method is working as expected
(do we have any test for it)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
