kgyrtkirk commented on a change in pull request #550: HIVE-21198 Introduce a
database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r345448803
##########
File path: storage-api/src/java/org/apache/hadoop/hive/common/TableName.java
##########
@@ -17,34 +17,45 @@
*/
package org.apache.hadoop.hive.common;
+import java.io.Serializable;
+import java.util.Objects;
+
/**
* A container for a fully qualified table name, i.e.
catalogname.databasename.tablename. Also
* includes utilities for string parsing.
*/
-public class TableName {
+public class TableName implements Serializable {
+
+ private static final long serialVersionUID = 1L;
+
+ /** Exception message thrown. */
+ private static final String ILL_ARG_EXCEPTION_MSG =
Review comment:
I don't really see the benefit of making this a static final string;
but anyway - I think the end goal is to stop the usage of any `tableName`
which contains `dbname` or any other stuff...and in that case the method in
which this is used should go away at some point - am I right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
