kgyrtkirk commented on a change in pull request #550: HIVE-21198 Introduce a
database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r345399636
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
##########
@@ -897,10 +897,10 @@ private void analyzeAlterTableProps(String[] qualified,
HashMap<String, String>
}
// if table is being modified to be external we need to make sure
existing table
// doesn't have enabled constraint since constraints are disallowed with
such tables
- else if(entry.getKey().equals("external") &&
entry.getValue().equals("true")){
- if(hasConstraintsEnabled(qualified[1])){
+ else if (entry.getKey().equals("external") &&
entry.getValue().equals("true")) {
+ if (hasConstraintsEnabled(tableName.getTable())) {
Review comment:
this seems fishy to me...I guess if we hit this line when we are issuing an
alter on a table of different database; things might go south...or is there
something I'm missing?
(this is of course outside of the scope of this ticket)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
