felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1337550422
##########
cpp/src/arrow/type.h:
##########
@@ -990,6 +990,71 @@ class ARROW_EXPORT LargeListType : public BaseListType {
std::string ComputeFingerprint() const override;
};
+/// \brief Type class for array of list views
+class ARROW_EXPORT ListViewType : public BaseListType {
+ public:
+ static constexpr Type::type type_id = Type::LIST_VIEW;
+ using offset_type = int32_t;
+
+ static constexpr const char* type_name() { return "list_view"; }
+
+ // ListView can contain any other logical value type
+ explicit ListViewType(const std::shared_ptr<DataType>& value_type)
Review Comment:
I'm being consistent with `ListType` and `LargeListType` (and all the
parametric types). I would like to fix these constructors and type factories
systematically instead of diverging from the existing pattern on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
