felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1337685748
##########
cpp/src/arrow/array/concatenate_test.cc:
##########
@@ -203,6 +203,54 @@ TEST_F(ConcatenateTest, LargeListType) {
});
}
+TEST_F(ConcatenateTest, ListViewType) {
+ Check([this](int32_t size, double null_probability, std::shared_ptr<Array>*
out) {
+ auto values_size = size * 4;
+ auto values = this->GeneratePrimitive<Int8Type>(values_size,
null_probability);
+
+ std::shared_ptr<Array> offsets;
+ auto offsets_vector = this->Offsets<int32_t>(values_size, size);
+ offsets_vector.front() = 0;
+ offsets_vector.back() = values_size;
Review Comment:
Unnecessary indeed. Removing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
