felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1337640192
##########
cpp/src/arrow/builder.cc:
##########
@@ -219,6 +219,20 @@ struct MakeBuilderImpl {
return Status::OK();
}
+ Status Visit(const ListViewType& list_view_type) {
+ std::shared_ptr<DataType> value_type = list_view_type.value_type();
+ ARROW_ASSIGN_OR_RAISE(auto value_builder, ChildBuilder(value_type));
+ out.reset(new ListViewBuilder(pool, std::move(value_builder),
std::move(type)));
+ return Status::OK();
+ }
+
+ Status Visit(const LargeListViewType& large_list_view_type) {
+ std::shared_ptr<DataType> value_type = large_list_view_type.value_type();
+ ARROW_ASSIGN_OR_RAISE(auto value_builder, ChildBuilder(value_type));
+ out.reset(new LargeListViewBuilder(pool, std::move(value_builder), type));
Review Comment:
In a fixup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
