[GitHub] [arrow] felipecrv commented on a diff in pull request #35345: GH-35344: [C++][Format] Implementation of the LIST_VIEW and LARGE_LIST_VIEW array formats

Tue, 26 Sep 2023 10:41:19 -0700 


felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1337575831


##########
cpp/src/arrow/scalar_test.cc:
##########
@@ -394,6 +394,10 @@ class TestRealScalar : public ::testing::Test {
 
   void TestLargeListOf() { TestListOf<LargeListScalar>(large_list(type_)); }
 
+  void TestListViewOf() { TestListOf<ListViewScalar>(list_view(type_)); }
+
+  void TestLargeListViewOf() { 
TestListOf<LargeListViewScalar>(large_list_view(type_)); }

Review Comment:
   I missed a list of types here, but after adding the list-view types, 
`MakeNullScalar` gets tested by `CheckMakeNullScalar`.
   
   
![image](https://github.com/apache/arrow/assets/207795/7cb5236c-f3d3-490b-b5d6-bcf6578952a3)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to