felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1337604991
##########
cpp/src/arrow/ipc/json_simple.cc:
##########
@@ -555,8 +563,9 @@ class ListConverter final : public
ConcreteConverter<ListConverter<TYPE>> {
if (json_obj.IsNull()) {
return this->AppendNull();
}
- RETURN_NOT_OK(builder_->Append());
// Extend the child converter with this JSON array
+ ARROW_ASSIGN_OR_RAISE(auto size, this->SizeOfJSONArray(json_obj));
+ RETURN_NOT_OK(builder_->Append(true, size));
Review Comment:
Do you have a name suggestion for "Add a valid or invalid list of a given
size"? Note that, per spec, nulls lists can have non-zero sizes in which case
filler values are added to the child array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
