felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1337638738
##########
cpp/src/arrow/compute/kernels/scalar_if_else_benchmark.cc:
##########
@@ -67,11 +67,15 @@ struct GetBytesProcessedVisitor {
}
template <typename ArrowType>
- enable_if_var_size_list<ArrowType, Status> Visit(const ArrowType& type) {
+ enable_if_var_length_list_like<ArrowType, Status> Visit(const ArrowType&
type) {
using ArrayType = typename TypeTraits<ArrowType>::ArrayType;
using OffsetType = typename TypeTraits<ArrowType>::OffsetType::c_type;
- total_bytes += (arr->length() + 1) * sizeof(OffsetType);
+ const auto num_offsets = is_list_view(type) ? arr->length() :
arr->length() + 1;
+ total_bytes += num_offsets * sizeof(OffsetType);
+ // NOTE: the sizes buffer is not counted when type is a list-view as that
+ // can make the throughput numbers look better just because the sizes add
+ // increase the number of bytes in the input.
Review Comment:
I'm fixing a typo here: ~add~ increase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
