alamb commented on code in PR #7884:
URL: https://github.com/apache/arrow-datafusion/pull/7884#discussion_r1366995727
##########
datafusion/physical-expr/src/intervals/interval_aritmetic.rs:
##########
@@ -1240,6 +1270,32 @@ mod tests {
Ok(())
}
+ #[test]
+ fn or_test() -> Result<()> {
Review Comment:
When I was writing this test I found there appears to be something wrong
with boolean interval handling.
Specifically, `open_open(.., ..)` always creates the interval `Interval {
lower: IntervalBound { value: Boolean(true), open: false }, upper:
IntervalBound { value: Boolean(false), open: false } }` regardless of the
arguments:
I tracked it down to the code in
https://github.com/apache/arrow-datafusion/blob/4591d82ccba6f52db535a377486362a35bfd84fb/datafusion/physical-expr/src/intervals/interval_aritmetic.rs#L250-L249
And I will file a follow on ticket about this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
