alamb commented on code in PR #7884:
URL: https://github.com/apache/arrow-datafusion/pull/7884#discussion_r1367792523
##########
datafusion/physical-expr/src/intervals/interval_aritmetic.rs:
##########
@@ -1240,6 +1270,32 @@ mod tests {
Ok(())
}
+ #[test]
+ fn or_test() -> Result<()> {
Review Comment:
> I will have solved all of these problems with the PR I am currently
working on.
The PR you are working on sounds great 🎉 . If it is possible, can you
possibly break it up into smaller parts (e.g perhaps we could break the "make
`Interval` fields not `pub` in one PR, and rework how `propagate_constraints`
works a a follow on PR?)
##########
datafusion/physical-expr/src/intervals/interval_aritmetic.rs:
##########
@@ -1240,6 +1270,32 @@ mod tests {
Ok(())
}
+ #[test]
+ fn or_test() -> Result<()> {
Review Comment:
> I will have solved all of these problems with the PR I am currently
working on.
The PR you are working on sounds great 🎉 . If it is possible, can you
possibly break it up into smaller parts (e.g perhaps we could break the "make
`Interval` fields not `pub` in one PR, and rework how `propagate_constraints`
works a a follow on PR?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
