alamb commented on code in PR #7884:
URL: https://github.com/apache/arrow-datafusion/pull/7884#discussion_r1367792390
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -344,8 +344,8 @@ impl PhysicalExpr for BinaryExpr {
let right_interval = children[1];
let (left, right) = if self.op.is_logic_operator() {
- // TODO: Currently, this implementation only supports the AND
operator
- // and does not require any further propagation. In the
future,
+ // TODO: Currently, this implementation only supports the AND/OR
operator
Review Comment:
Sounds good -- I don't fully understand what propagate constraints is used
for. I think postponing any extra work until your refactoring is complete
sounds like a good idea to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
