alamb commented on code in PR #7884:
URL: https://github.com/apache/arrow-datafusion/pull/7884#discussion_r1367269492
##########
datafusion/physical-expr/src/intervals/interval_aritmetic.rs:
##########
@@ -432,6 +432,27 @@ impl Interval {
}
}
+ /// Compute the logical disjunction of this (boolean) interval with the
given boolean interval.
+ pub(crate) fn or<T: Borrow<Interval>>(&self, other: T) -> Result<Interval>
{
+ let rhs = other.borrow();
+ if self.get_datatype()? != DataType::Boolean
+ && rhs.get_datatype()? != DataType::Boolean
Review Comment:
Good call -- thank you @Weijun-H
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
