berkaysynnada commented on code in PR #7884:
URL: https://github.com/apache/arrow-datafusion/pull/7884#discussion_r1367737282
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -344,8 +344,8 @@ impl PhysicalExpr for BinaryExpr {
let right_interval = children[1];
let (left, right) = if self.op.is_logic_operator() {
- // TODO: Currently, this implementation only supports the AND
operator
- // and does not require any further propagation. In the
future,
+ // TODO: Currently, this implementation only supports the AND/OR
operator
Review Comment:
I'm slightly changing the API here. It will be more understandable and easy
to add new supports. Since the current version is written by overfitting the
AND operator, adding OR support may be a challenge. Undoubtedly, it will be
easier to add it after my refactoring PR arrives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
