berkaysynnada commented on code in PR #7884:
URL: https://github.com/apache/arrow-datafusion/pull/7884#discussion_r1367736695
##########
datafusion/physical-expr/src/intervals/interval_aritmetic.rs:
##########
@@ -1240,6 +1270,32 @@ mod tests {
Ok(())
}
+ #[test]
+ fn or_test() -> Result<()> {
Review Comment:
When you create an interval with an open bound, if it is a lower bound, it
can be `(false` or `(true`. `(false` can be represented as `[true`. For an
upper bound case, `true)` rounds down to `false]`. That's why this result comes
in that way.
But of course, you are right. We should not give the chance to create an
invalid interval. Especially for boolean intervals, open_open case always gives
an invalid interval, meaning that it needs to return an error regardless of the
interval values (false or true). I will have solved all of these problems with
the PR I am currently working on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
