wjones127 commented on code in PR #1326: URL: https://github.com/apache/arrow-adbc/pull/1326#discussion_r1406475818
########## rust/src/lib.rs: ########## @@ -64,25 +64,26 @@ pub mod objects; use std::collections::HashMap; +use arrow_adbc_sys as adbc; Review Comment: > I know Go users often prefer to avoid CGO entirely if not required as it makes cross-compilation and static binaries harder The only time I've had real issues in Rust like this was with `openblas-src`, and that was because of the Fortran compiler dependency. It's not uncommon in Rust to have some C dependencies; the most popular example is [openssl](https://crates.io/crates/openssl), which depends on `openssl-sys`. I don't feel particularly strongly either way. I do suspect eventually someone might ask for a small pure-Rust version, and it seems reasonable that we build with that in mind. The amount of duplication doesn't seem that high to me. I also do like the idea of having the bindings checked in somehow. It makes the code much easier to browse in GitHub. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
