lidavidm commented on code in PR #1326: URL: https://github.com/apache/arrow-adbc/pull/1326#discussion_r1406600127
########## rust/src/lib.rs: ########## @@ -64,25 +64,26 @@ pub mod objects; use std::collections::HashMap; +use arrow_adbc_sys as adbc; Review Comment: My main concern is locking us into a path that will be hard to back out of. I suppose if it's _only_ constant values then we can always copy them over later and break the dependency, but beyond that it may get painful if it turns out that pure-Rust is a major user concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
