kou commented on code in PR #40697:
URL: https://github.com/apache/arrow/pull/40697#discussion_r1535060022
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -80,6 +74,12 @@ namespace liborc = orc;
} \
catch (const liborc::NotImplementedYet& e) { \
return Status::NotImplemented(e.what()); \
+ } \
+ catch (const std::exception& e) { \
+ return Status::Invalid(e.what()); \
+ } \
+ catch (...) { \
+ return Status::UnknownError("ORC error"); \
Review Comment:
Do we need this? (Is `catch (const std::exception& e)` enough?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
