jorisvandenbossche commented on code in PR #40697:
URL: https://github.com/apache/arrow/pull/40697#discussion_r1535231818
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -183,6 +183,22 @@ liborc::RowReaderOptions default_row_reader_options() {
return options;
}
+// Proactively check the availability of timezone database.
+// Remove it once https://issues.apache.org/jira/browse/ORC-1661 has been
fixed.
+Status check_timezone_database_availability() {
Review Comment:
@wgtmac what would be the error message that you get when not doing the
above now that you are catching the exceptions?
Because one reason to keep this, is to provide an informative error message
(most Windows users will see this the first time, so I think it is important to
give some guidance in the error message, and not just a "file not found").
(to avoid getting out of sync with ORC, we could add an ORC version check
and only do this for ORC<2?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
