wgtmac commented on code in PR #40697:
URL: https://github.com/apache/arrow/pull/40697#discussion_r1535243397
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -183,6 +183,22 @@ liborc::RowReaderOptions default_row_reader_options() {
return options;
}
+// Proactively check the availability of timezone database.
+// Remove it once https://issues.apache.org/jira/browse/ORC-1661 has been
fixed.
+Status check_timezone_database_availability() {
Review Comment:
> I'd rather not do this, and let ORC fix the issue by making the timezone
file optional (what is it used for exactly?).
ORC has two timestamp types: timestamp (namely timestamp_without_timezone)
and timestamp_instant (namely timestamp_with_local_timezone).
- timestamp: writer keeps the writer timezone in the stripe footer, and
reader uses reader timezone to recover the same wall clock time by converting
from writer timezone to reader timezone. that's why the reader try to call
`getLocalTimezone()` on startup.
- timestamp_with_local_timezone: use UTC everywhere so it does not have any
conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
