pitrou commented on code in PR #40697:
URL: https://github.com/apache/arrow/pull/40697#discussion_r1535209682


##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -183,6 +183,22 @@ liborc::RowReaderOptions default_row_reader_options() {
   return options;
 }
 
+// Proactively check the availability of timezone database.
+// Remove it once https://issues.apache.org/jira/browse/ORC-1661 has been 
fixed.
+Status check_timezone_database_availability() {

Review Comment:
   Is this useful if we're correctly catching exceptions? I'm afraid this could 
get out of sync with ORC's own timezone loading code.
   
   I'd rather not do this, and let ORC fix the issue by making the timezone 
file optional (what is it used for exactly?).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to