pitrou commented on code in PR #40697:
URL: https://github.com/apache/arrow/pull/40697#discussion_r1535255652
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -183,6 +183,22 @@ liborc::RowReaderOptions default_row_reader_options() {
return options;
}
+// Proactively check the availability of timezone database.
+// Remove it once https://issues.apache.org/jira/browse/ORC-1661 has been
fixed.
+Status check_timezone_database_availability() {
Review Comment:
> * timestamp: writer keeps the writer timezone in the stripe footer, and
reader uses reader timezone to recover the same wall clock time by converting
from writer timezone to reader timezone. that's why the reader try to call
`getLocalTimezone()` on startup.
If we convert, we should convert to UTC instead of converting to the local
timezone. That's how Arrow timestamps work (but we still need a timezone DB for
the conversion anyway):
https://github.com/apache/arrow/blob/51817917e1436c8799ed382d160798060cd76652/format/Schema.fbs#L283-L288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
