wgtmac commented on code in PR #40697:
URL: https://github.com/apache/arrow/pull/40697#discussion_r1537023738
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -183,6 +183,22 @@ liborc::RowReaderOptions default_row_reader_options() {
return options;
}
+// Proactively check the availability of timezone database.
+// Remove it once https://issues.apache.org/jira/browse/ORC-1661 has been
fixed.
+Status check_timezone_database_availability() {
Review Comment:
> If we convert, we should convert to UTC instead of converting to the local
timezone.
I know that's a better idea. However, this was the design choice of ORC
timestamp type which originates from Hive. So it would be better to use
timestamp_instant type in favor of the old timestamp type in ORC at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
