pitrou commented on code in PR #40594:
URL: https://github.com/apache/arrow/pull/40594#discussion_r1858097618
##########
cpp/src/parquet/encoding.h:
##########
@@ -158,6 +158,10 @@ class Encoder {
virtual Encoding::type encoding() const = 0;
virtual void Put(const ::arrow::Array& values) = 0;
+ // Report the number of bytes before encoding that have been written
+ // to the encoder since the last report. Note that this call is not
+ // idempotent because it resets the internal counter.
+ virtual int64_t ReportUnencodedDataBytes() = 0;
Review Comment:
Sure, but it also doesn't make sense to maintain (and test) some code that
has no use case, right?
At worse this can be put on a derived class :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
