wgtmac commented on code in PR #40594:
URL: https://github.com/apache/arrow/pull/40594#discussion_r1860677581
##########
cpp/src/parquet/page_index.h:
##########
@@ -76,6 +74,18 @@ class PARQUET_EXPORT ColumnIndex {
/// \brief A vector of page indices for non-null pages.
virtual const std::vector<int32_t>& non_null_page_indices() const = 0;
+
+ /// \brief Whether repetition level histogram is available.
+ virtual bool has_repetition_level_histograms() const = 0;
+
+ /// \brief Whether definition level histogram is available.
+ virtual bool has_definition_level_histograms() const = 0;
+
+ /// \brief List of repetition level histograms for each page concatenated
together.
+ virtual const std::vector<int64_t>& repetition_level_histograms() const = 0;
Review Comment:
All other functions in this class return `const std::vector &` already, so
it would be better to keep consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
