WillAyd commented on code in PR #693:
URL: https://github.com/apache/arrow-nanoarrow/pull/693#discussion_r1889587352
##########
src/nanoarrow/ipc/decoder.c:
##########
@@ -1485,14 +1580,27 @@ static ArrowErrorCode
ArrowIpcMakeBufferFromShared(struct ArrowIpcBufferFactory*
struct ArrowBufferView*
dst_view,
struct ArrowBuffer* dst,
struct ArrowError* error) {
- NANOARROW_UNUSED(error);
-
struct ArrowIpcSharedBuffer* shared =
(struct ArrowIpcSharedBuffer*)factory->private_data;
- ArrowBufferReset(dst);
- ArrowIpcSharedBufferClone(shared, dst);
- dst->data += src->body_offset_bytes;
- dst->size_bytes = src->buffer_length_bytes;
+
+ int needs_decompression = 0;
Review Comment:
Ultra nit but is there any reason why we shy away from using stdbool?
##########
python/pyproject.toml:
##########
@@ -45,6 +45,11 @@ requires = [
build-backend = "mesonpy"
[tool.meson-python.args]
+# Consistent version for zstd, rather than attempting to delocate whatever
Review Comment:
When you say delocate are you just referring to just to macOS or does this
affect all platforms?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
