paleolimbot commented on code in PR #693:
URL: https://github.com/apache/arrow-nanoarrow/pull/693#discussion_r1889596368
##########
src/nanoarrow/ipc/decoder.c:
##########
@@ -1485,14 +1580,27 @@ static ArrowErrorCode
ArrowIpcMakeBufferFromShared(struct ArrowIpcBufferFactory*
struct ArrowBufferView*
dst_view,
struct ArrowBuffer* dst,
struct ArrowError* error) {
- NANOARROW_UNUSED(error);
-
struct ArrowIpcSharedBuffer* shared =
(struct ArrowIpcSharedBuffer*)factory->private_data;
- ArrowBufferReset(dst);
- ArrowIpcSharedBufferClone(shared, dst);
- dst->data += src->body_offset_bytes;
- dst->size_bytes = src->buffer_length_bytes;
+
+ int needs_decompression = 0;
Review Comment:
Early on I was trying to minimize the number of C headers that were included
via `nanoarrow.h` directly. Because there are some boolean flag arguments
there, the precedent spread elsewhere for consistency (sort of...I think there
are one or two `char`s instead of `int`s).
Possibly better would be a `#define ArrowBoolean int` or `typedef
ArrowBoolean int` (or char), or just include `stdbool.h`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
