WillAyd commented on code in PR #693:
URL: https://github.com/apache/arrow-nanoarrow/pull/693#discussion_r1889617706


##########
python/pyproject.toml:
##########
@@ -45,6 +45,11 @@ requires = [
 build-backend = "mesonpy"
 
 [tool.meson-python.args]
+# Consistent version for zstd, rather than attempting to delocate whatever

Review Comment:
   Ah ok. I can take a look too. 
   
   Thinking out loud, we might need to be careful if it's the wheel build 
itself installing the libraries (because the subproject meson configurations 
instruct the build system to do so) or if it's the wheel repair jobs that are 
bundling improper libraries. I'm guessing it's the former. 
   
   I think we could add the following to pyproject.toml to prevent the former 
issue:
   
   [tool.meson-python.args]
   install = ['--skip-subprojects']
   
   Or possibly even statically link the zstd subproject (?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to