WillAyd commented on code in PR #693:
URL: https://github.com/apache/arrow-nanoarrow/pull/693#discussion_r1889618798
##########
src/nanoarrow/ipc/decoder.c:
##########
@@ -1485,14 +1580,27 @@ static ArrowErrorCode
ArrowIpcMakeBufferFromShared(struct ArrowIpcBufferFactory*
struct ArrowBufferView*
dst_view,
struct ArrowBuffer* dst,
struct ArrowError* error) {
- NANOARROW_UNUSED(error);
-
struct ArrowIpcSharedBuffer* shared =
(struct ArrowIpcSharedBuffer*)factory->private_data;
- ArrowBufferReset(dst);
- ArrowIpcSharedBufferClone(shared, dst);
- dst->data += src->body_offset_bytes;
- dst->size_bytes = src->buffer_length_bytes;
+
+ int needs_decompression = 0;
Review Comment:
Sounds good. Not important enough to change I think.
Can also wait 20 years for C23 to be fully supported by MSVC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
