WillAyd commented on code in PR #2740:
URL: https://github.com/apache/arrow-adbc/pull/2740#discussion_r2068770636
##########
c/driver/framework/CMakeLists.txt:
##########
@@ -35,6 +36,7 @@ if(ADBC_BUILD_TESTS)
base_driver_test.cc
EXTRA_LINK_LIBS
adbc_driver_framework)
+ target_compile_definitions(adbc-driver-framework-test PRIVATE ADBC_STATIC)
Review Comment:
Ah nevermind...I see the issue causing the failures in CI currently. The
`adbc_driver_postgresql` and `adbc_driver_sqlite` targets both link against
`adbc_driver_common` and `adbc_driver_framework`. The common and framework
libraries are both explicitly declared as STATIC in the current CMake
configuration, but the postgresql and sqlite drivers are not. So by making the
`ADBC_STATIC` define PUBLIC on the common and framework libraries, I think
CMake is also forcing the postgresql and sqlite drivers to define that as well,
but that then interferes with their ability to properly dllexport symbols
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
