WillAyd commented on code in PR #2740:
URL: https://github.com/apache/arrow-adbc/pull/2740#discussion_r2066222982
##########
c/driver/framework/CMakeLists.txt:
##########
@@ -35,6 +36,7 @@ if(ADBC_BUILD_TESTS)
base_driver_test.cc
EXTRA_LINK_LIBS
adbc_driver_framework)
+ target_compile_definitions(adbc-driver-framework-test PRIVATE ADBC_STATIC)
Review Comment:
I don't see the comment I thought I left originally but I wanted to check
this was the desired behavior. The way the macro is now, the library itself and
anything that links to it must define ADBC_STATIC. The former makes sense, but
we don't want the downstream target to have to define that, right? @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
