WillAyd commented on code in PR #2740:
URL: https://github.com/apache/arrow-adbc/pull/2740#discussion_r2063800036
##########
c/include/arrow-adbc/adbc.h:
##########
@@ -152,15 +152,19 @@ struct ArrowArrayStream {
// Storage class macros for Windows
// Allow overriding/aliasing with application-defined macros
#if !defined(ADBC_EXPORT)
-#if defined(_WIN32)
+#if (defined(_WIN32) || defined(__CYGWIN__)) && defined(ADBC_BUILD_DLL)
Review Comment:
Is the idea that downstream targets that link to a static arrow library
would also need to define `ADBC_STATIC`? The current design necessitates that
on Windows, but I'm not sure that is correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
