kou commented on code in PR #2740:
URL: https://github.com/apache/arrow-adbc/pull/2740#discussion_r2067910290
##########
c/driver/framework/CMakeLists.txt:
##########
@@ -35,6 +36,7 @@ if(ADBC_BUILD_TESTS)
base_driver_test.cc
EXTRA_LINK_LIBS
adbc_driver_framework)
+ target_compile_definitions(adbc-driver-framework-test PRIVATE ADBC_STATIC)
Review Comment:
Hmm. Not right. All downstream targets also need to define `ADBC_STATIC`. We
can automate it by changing `target_compile_definitions(adbc_driver_framework
PRIVATE ADBC_EXPORTING ADBC_STATIC)` to:
```cmake
target_compile_definitions(adbc_driver_framework PRIVATE ADBC_EXPORTING)
target_compile_definitions(adbc_driver_framework PUBLIC ADBC_STATIC)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
