WillAyd commented on code in PR #2740:
URL: https://github.com/apache/arrow-adbc/pull/2740#discussion_r2068762886
##########
c/driver/framework/CMakeLists.txt:
##########
@@ -35,6 +36,7 @@ if(ADBC_BUILD_TESTS)
base_driver_test.cc
EXTRA_LINK_LIBS
adbc_driver_framework)
+ target_compile_definitions(adbc-driver-framework-test PRIVATE ADBC_STATIC)
Review Comment:
This works great for targets that are explicitly defined with
`add_library(<TARGET> STATIC ...)` but doesn't seem to work with the
`add_arrow_lib` function. From looking at it, my understanding is that
`add_arrow_lib` can build both SHARED and STATIC libraries, depending on
whether `ADBC_BUILD_SHARED` and `ADBC_BUILD_STATIC` are set.
Simply doing:
```cmake
if(ADBC_BUILD_STATIC)
target_compile_definitions(<TARGET> PUBLIC ADBC_STATIC)
endif()
```
I think can end up defining ADBC_STATIC for the shared libraries in the case
when ADBC_BUILD_STATIC and ADBC_BUILD_SHARED are both defined.
To solve that, do I need to extend the `add_arrow_lib` function to accept an
argument like `STATIC_COMPILER_FLAGS`? There is already a `SHARED_LINK_FLAGS`
argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
