kou commented on PR #2740: URL: https://github.com/apache/arrow-adbc/pull/2740#issuecomment-2836912619
> > We can use the same approach (`Cflags.private`) with pkg-config on Windows (MSYS2). > > FWIW I don't see Cflags.private as a documented field for pkg-config: > > https://people.freedesktop.org/~dbn/pkg-config-guide.html Oh, I didn't know it. But pkgconf that is a replacement of pkg-config supports `Cflags.private`: http://pkgconf.org/features.html So we can use `Cflags.private`. > From that I assume it is Libs.private that should be the right place for this? We should not use `Libs.private` for this because `-DADBC_STATIC` is needed for compiling phase not linking phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
