edponce commented on a change in pull request #11147:
URL: https://github.com/apache/arrow/pull/11147#discussion_r708418292
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -899,26 +900,26 @@ cdef class _TakeOptions(FunctionOptions):
class TakeOptions(_TakeOptions):
- def __init__(self, *, boundscheck=True):
+ def __init__(self, boundscheck=True):
Review comment:
I removed all the keyword arguments simply to get a code review like
yours. How do we decide what options should be positional and which ones should
be keyword-only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
