jorisvandenbossche commented on a change in pull request #11147:
URL: https://github.com/apache/arrow/pull/11147#discussion_r709256716
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -899,26 +900,26 @@ cdef class _TakeOptions(FunctionOptions):
class TakeOptions(_TakeOptions):
- def __init__(self, *, boundscheck=True):
+ def __init__(self, boundscheck=True):
Review comment:
Using the rule of @westonpace to have keywords that are optional / have
a default as keyword-only, is probably a good start. We can see if that gives
any changes compared to the current situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
