edponce commented on a change in pull request #11147:
URL: https://github.com/apache/arrow/pull/11147#discussion_r709283521



##########
File path: python/pyarrow/_compute.pyx
##########
@@ -899,26 +900,26 @@ cdef class _TakeOptions(FunctionOptions):
 
 
 class TakeOptions(_TakeOptions):
-    def __init__(self, *, boundscheck=True):
+    def __init__(self, boundscheck=True):

Review comment:
       Ok, I started doing that (still WIP), but also noticed that in C++ 
FunctionOptions, there are inconsistencies between the number of constructors, 
the availability of a `Defaults()` method, and data members. I am looking into 
this (need to reach out to other developers) to check what changes we are 
allowed to make at this time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to