viirya commented on code in PR #226:
URL: https://github.com/apache/datafusion-comet/pull/226#discussion_r1575679390
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1646,6 +1647,37 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
None
}
+ case Murmur3Hash(children, seed) if children.forall(c =>
supportedDataType(c.dataType)) =>
+ // TODO: support list/map/struct type for murmur3 hash
Review Comment:
This TODO seems unnecessary as other expressions also don't support nested
types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
