advancedxy commented on code in PR #226:
URL: https://github.com/apache/datafusion-comet/pull/226#discussion_r1575752513
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -983,8 +983,7 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
- // TODO: enable this when we add md5 function to Comet
- ignore("md5") {
+ test("md5") {
Review Comment:
> I remember we explicitly disable it because DataFusion crypto_expressions
feature includes blake3 which cannot be built on Mac platform.
Do you have any issues to track this one? I think I can build DataFusion by
default on Apple Silicon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
