advancedxy commented on code in PR #226: URL: https://github.com/apache/datafusion-comet/pull/226#discussion_r1575746005
########## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ########## @@ -983,8 +983,7 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper { } } - // TODO: enable this when we add md5 function to Comet - ignore("md5") { + test("md5") { Review Comment: hmm, I think [`crypto_expressions`](https://github.com/apache/datafusion/blob/main/datafusion/core/Cargo.toml#L52) is enabled as default features in DataFusion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org