advancedxy commented on code in PR #226:
URL: https://github.com/apache/datafusion-comet/pull/226#discussion_r1576520191
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -983,8 +983,7 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
- // TODO: enable this when we add md5 function to Comet
- ignore("md5") {
+ test("md5") {
Review Comment:
> But I'm wondering as we don't add back crypto_expressions feature, is md5
function working? I think it is guarded by this feature in DataFusion.
That's new.
I did a quick digging. It seems that the crypto expressions are enabled in
datafusion-functions as it's enabled as default features.
Let me ensure the crypto_expressions feature is enabled then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
