advancedxy commented on code in PR #226:
URL: https://github.com/apache/datafusion-comet/pull/226#discussion_r1575732635
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1350,7 +1350,7 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
scalarExprToProto("lower", childExpr)
case Md5(child) =>
- val childExpr = exprToProtoInternal(Cast(child, StringType), inputs)
+ val childExpr = exprToProtoInternal(child, inputs)
Review Comment:
hmmm, I think binary support is added by this PR:
https://github.com/apache/datafusion/pull/3124, which is pretty old.
Anyway, currently all the digest func supports both utf8 and binary input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
